Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1179 added sorting by status #1195

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

nazarstig
Copy link
Contributor

No description provided.

@alrom
Copy link
Contributor

alrom commented Aug 21, 2023

In the previous PR sorting had a reverse ordering or not? Maybe, change indexes to reversing and start them from 10. Like this: NeverLogged = 30, Accepted = 20, Blocked = 10. And don't forget about migration for updating existing data in DB.

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@DmyMi DmyMi merged commit ec422c9 into develop Aug 22, 2023
5 checks passed
@DmyMi DmyMi deleted the nazarstig/ministryadmin_sorting branch August 22, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants